Skip to content

fix(gateway): verify effective provider transport before receiver operations - #5652

Merged
devantler merged 1 commit into
mainfrom
codex/email-effective-transport-5448-23e2
Nov 1, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/email-effective-transport-5448-23e2

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The gateway's requested transport setting does not prove what the load balancer has applied. Recovery needs that confirmation before changing gateway protection.

What

Require confirmed provider state before receiver changes and successful public verification. Keep forwarding disabled while preparing its later rollout.

Part of #5448

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 42 minutes.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between aad3cad and 18a6ff3.

Files selected for processing: 11
  • .github/actions/deploy-prod/action.yml
  • docs/operations/gateway-receiver-boundary.md
  • scripts/gateway-receiver-binding/binding.go
  • scripts/gateway-receiver-binding/binding_test.go
  • scripts/gateway-receiver-binding/provider.go
  • scripts/gateway-receiver-binding/provider_guard.go
  • scripts/gateway-receiver-binding/provider_guard_test.go
  • scripts/gateway-receiver-binding/provider_test.go
  • scripts/gateway-receiver-binding/registry.go
  • scripts/gateway-receiver-binding/selected.go
  • scripts/gateway-receiver-binding/verify.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

cr:no-gate@18a6ff3 reason=service-failure

CodeRabbit declined this head's review because its included review quota is exhausted; its current-head response establishes the refusal. The reviewed artifact guard admits continuation and no findings were published. I am advancing to the next lane; no green review is claimed.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T05:48:45.909460Z 18a6ff3 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 18a6ff35ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Validation at 18a6ff35cef1c1dd75fe6650fc9042e281deb772: affected package tests with race detection, vet and lint pass; the deployment-order regression passes all 32 cases. CI 41276986362 is successful, and the native PR page confirms all required checks pass. Codex's current-head review is clean; complete conversation, review and inline-comment reads contain no unresolved findings. The newer main changes do not overlap this change, and the native merge state is clean.

The real provider observation remains unverified: its credential is available only in the protected deployment. Native HTTP controls establish request and failure boundaries but do not establish current provider state. The draft stays pending the narrow maintainer exception for one protected deployment trial; normal CI, queue and automatic recovery remain required. This change keeps transport disabled and does not complete #5448 or #5412.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

At 18a6ff35cef1c1dd75fe6650fc9042e281deb772, current-head CI and the Codex review are successful; refreshed conversation, inline-review and thread inventories contain no findings. Native GitHub confirms all checks pass and no base conflict. Current main changes do not overlap the receiver implementation.

The maintainer has authorized one protected deployment trial of this head in the interactive session. This is the narrow readiness exception for the real provider observation, which requires the protected deployment credential; that user evaluation is still unverified until the trial runs. Promotion and queue checks, current-head validation and automatic recovery remain enforced. Forwarding stays disabled. Enqueueing will wait for the currently running production recovery to settle. This does not complete #5448 or #5412.

@devantler
devantler marked this pull request as ready for review November 1, 2026 07:55
@devantler
devantler added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit dbd0cd4 Nov 1, 2026
54 checks passed
@devantler
devantler deleted the codex/email-effective-transport-5448-23e2 branch November 1, 2026 11:38
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 1, 2026
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Merged as dbd0cd4d1a10896d293a07107eeb28e2f944fa64 after the protected deployment of reviewed head 18a6ff35cef1c1dd75fe6650fc9042e281deb772. Trial 41300692395 passed, including the production provider observation and four public-route probes. The selected fence was verified without another fence write.

The published manifest is sha256:24072cced11adde9c5e93e78fad0c601b549ee47aee60460a1d61be120592e03. Enforced deployment checks verified its signature, SBOM and provenance, and rejected an intentionally wrong signing identity. A fresh read-only production observation found that digest Ready in the source and all six root reconciliation layers, at their current generations. Validate Main, Code Quality and the main push checks passed; all 69 reported checks are settled without failure.

Separately, the existing live peer-refusal trial passed at 85671b538cd90b174a2441ff70030db7da6d80f1: ten direct TLS attempts were refused, both HTTP controls answered, and cleanup succeeded. Original-client transport, independent startup recovery and Email acceptance remain part of #5448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant